23 Nov
2020
23 Nov
'20
10:53 p.m.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47874 )
Change subject: lspcon_i2c_spi.c: Fix style ......................................................................
Patch Set 1: Code-Review-2
C99 should allow for the iterator declaration to be inside the loop construct predicate. I think the CrOS tree should be fixed and not here imho.
--
To view, visit https://review.coreboot.org/c/flashrom/+/47874
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4068ae7bdf6e053606cb063f7781dbb2d77792ff
Gerrit-Change-Number: 47874
Gerrit-PatchSet: 1
Gerrit-Owner: Shiyu Sun sshiyu@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Nov 2020 22:53:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment