Hello Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/28910
to review the following change.
Change subject: flashchips: Add W25Q128J ......................................................................
flashchips: Add W25Q128J
Port the code from chromeos flashrom. Tested using W25Q128J in SPI mode.
Change-Id: I38397a0c831407afa21cddca8485664576fce92c Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M flashchips.c M flashchips.h 2 files changed, 38 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/28910/1
diff --git a/flashchips.c b/flashchips.c index d2773d6..3c8dfe5 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15666,6 +15666,43 @@ .voltage = {1650, 1950}, /* Fast read (0x0B) and multi I/O supported */ },
+ { + .vendor = "Winbond", + .name = "W25Q128J", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25Q128J, + .total_size = 16384, + .page_size = 256, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2700, 3600}, + }, + { .vendor = "Winbond", .name = "W25Q16.W", diff --git a/flashchips.h b/flashchips.h index 6bc4094..7ec7aab 100644 --- a/flashchips.h +++ b/flashchips.h @@ -925,6 +925,7 @@ #define WINBOND_NEX_W25Q32_W 0x6016 /* W25Q32DW; W25Q32FV in QPI mode */ #define WINBOND_NEX_W25Q64_W 0x6017 /* W25Q64DW; W25Q64FV in QPI mode */ #define WINBOND_NEX_W25Q128_W 0x6018 /* W25Q128FW; W25Q128FV in QPI mode */ +#define WINBOND_NEX_W25Q128J 0x7018 /* W25Q128J */
#define WINBOND_ID 0xDA /* Winbond */ #define WINBOND_W19B160BB 0x49