Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41532 )
Change subject: raiden_debug_spi.c: Add protocol based configuration to init ......................................................................
Patch Set 23: Code-Review+1
(3 comments)
https://review.coreboot.org/c/flashrom/+/41532/20/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41532/20/raiden_debug_spi.c@211 PS20, Line 211: bugs
The definition of the field itself creates this problem: […]
I see. Ugh. Welp, it can be fixed later.
https://review.coreboot.org/c/flashrom/+/41532/20/raiden_debug_spi.c@729 PS20, Line 729: free(ctx_data);
That was months ago.
Oh well.
https://review.coreboot.org/c/flashrom/+/41532/23/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41532/23/raiden_debug_spi.c@675 PS23, Line 675: switch Still missing a space