Attention is currently required from: Angel Pons, Light.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62764 )
Change subject: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error
......................................................................
Patch Set 6:
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62764/comment/d4820da0_5d4e2a6d
PS6, Line 507: assert(j >= 12);
I am not sure, are we using assert in code? I am wondering what other people think.
Aarya, this is a question not to you :) Let's wait a bit and see what others think.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5921cc571f3dca5188ca1973dba6ececbcbe2f39
Gerrit-Change-Number: 62764
Gerrit-PatchSet: 6
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Light
aarya.chaumal@gmail.com
Gerrit-Comment-Date: Wed, 23 Mar 2022 07:58:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment