Attention is currently required from: Aarya, Alexander Goncharov, Nikolai Artemiev, Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/82393?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: erasure_layout: Fix get_flash_region bug
......................................................................
Patch Set 16: Code-Review+2
(2 comments)
Patchset:
PS16:
This is going great (one tiny comment that I found).
And, we have one more Co-developer!
Nikolai, it would be great if you can review the end result of what we have done :) Thank you so much!
File tests/erase_func_algo.c:
https://review.coreboot.org/c/flashrom/+/82393/comment/d8bb0b26_fa98d91d?usp... :
PS16, Line 89: printf("Eraser called with blockaddr=0x%x, blocklen=0x%x\n", blockaddr, blocklen);
I only now noticed, perhaps we can log erase_func here too (it is logged in `block_erase_chip_with_protected_region`)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82393?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ic5bf9d0f0e4a94c48d6f6e74e3cb9cccdc7adec9
Gerrit-Change-Number: 82393
Gerrit-PatchSet: 16
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Aarya
aarya.chaumal@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Mon, 03 Jun 2024 03:28:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes