Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/84856?usp=email )
Change subject: linux_mtd: fix build with clang >= 19 ......................................................................
linux_mtd: fix build with clang >= 19
Starting with version 19, clang issues a warning when using `strlen()` for initializing a static array's size. This causes the build to fail as the project also sets `-Werror`.
This is fixed by using `sizeof()` instead, which is guaranteed to be evaluated at compilation time and therefore not triggering the problematic warning.
Change-Id: If470a65702e9ae08e4303123a0014e53a1fee56e Signed-off-by: Arnaud Ferraris arnaud.ferraris@collabora.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/84856 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Maximilian Brune maximilian.brune@9elements.com Reviewed-by: Anastasia Klimchuk aklm@chromium.org --- M linux_mtd.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved Maximilian Brune: Looks good to me, but someone else must approve
diff --git a/linux_mtd.c b/linux_mtd.c index d5fc509..b1d0255 100644 --- a/linux_mtd.c +++ b/linux_mtd.c @@ -49,7 +49,7 @@ int i; size_t bytes_read; FILE *fp; - char path[strlen(LINUX_MTD_SYSFS_ROOT) + 32]; + char path[sizeof(LINUX_MTD_SYSFS_ROOT) + 31];
snprintf(path, sizeof(path), "%s/%s", sysfs_path, filename);