Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/34405 )
Change subject: cli_classic: Fix Memory leak ......................................................................
cli_classic: Fix Memory leak
Found-by: scan-build 7.0.1-8 Change-Id: I84e642b57b95953f376569e443ef8d8eda7bf98f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/flashrom/+/34405 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M cli_classic.c 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/cli_classic.c b/cli_classic.c index b79f953..0591bfe 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -383,6 +383,11 @@ fprintf(stderr, "Log file not supported in standalone mode. Aborting.\n"); cli_classic_abort_usage(); #else /* STANDALONE */ + if (logfile) { + fprintf(stderr, "Warning: -o/--output specified multiple times.\n"); + free(logfile); + } + logfile = strdup(optarg); if (logfile[0] == '\0') { fprintf(stderr, "No log filename specified.\n");