[flashrom-gerrit] Change in flashrom[staging]: chipset_enable: Add support for Intel Skylake

[Youness Alaoui (Code Review)]

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/18925 )

Change subject: chipset_enable: Add support for Intel Skylake
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/18925/2/chipset_enable.c
File chipset_enable.c:

Line 852: 
Here, I would do :
   pci_get_dev(pci_acc, dev->domain, dev->bus, dev->dev, 5);
Might even make that '5' into a #define to avoid having the magic number here.
   #define PCH_100_SPI_INTERFACE_PCI_FUNCTION

Line 858: 
Any reason this doesn't call enable_flash_ich_fwh ? I'm having a hard time understanding what the FWH is/does and why it's needed for PCH <=9 but not for PCH 100.