Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83717?usp=email )
Change subject: flashchips: add GD25LF256F ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/83717/comment/2ca9b198_ad6316b7?usp... : PS1, Line 13: I will have to email you the datasheet.
I got the datasheet, thank you! You can remove this sentence from commit message.
Done
https://review.coreboot.org/c/flashrom/+/83717/comment/4c914fe1_2e3ae2b6?usp... : PS1, Line 15: protestion
A typo: protestion -> protection
Done
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83717/comment/44d7e051_569acb73?usp... : PS1, Line 6736: GD25LF256F
Could you please move this definition to be after GD25LF128E, in the same order as you did for IDs i […]
Done
https://review.coreboot.org/c/flashrom/+/83717/comment/d6cd8158_6998af28?usp... : PS1, Line 6785: BP4
Lets put the full comment here, as usual: […]
Done