Attention is currently required from: Edward O'Callaghan, Angel Pons, Liam Flaherty.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69933 )
Change subject: tree/: Convert unlock func ptr into enumerate values
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69933/comment/c5300711_088dbd8e
PS4, Line 9: By converting
I think you don't need "By", just start with Converting.
Because the sentence goes like:
Converting X allows for Y
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69933
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie5c5db1b09d07e1a549990d6f5a622fae4c83233
Gerrit-Change-Number: 69933
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Liam Flaherty
liamflaherty@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Liam Flaherty
liamflaherty@chromium.org
Gerrit-Comment-Date: Tue, 13 Dec 2022 05:43:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment