Attention is currently required from: Namyoon Woo, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54721 )
Change subject: dummyflasher.c: Move 'spi_write_256_chunksize' into emu_data
......................................................................
Patch Set 2:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54721/comment/e1d2699a_03a3bf00
PS2, Line 713: data->spi_write_256_chunksize = atoi(tmp);
For another patch: This can result in overflow because `spi_write_256_chunksize` is of an unsigned type.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54721
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I633f4df4bd47e661cd69801f21910b667899d505
Gerrit-Change-Number: 54721
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Namyoon Woo
namyoon@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Namyoon Woo
namyoon@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Sun, 23 May 2021 10:16:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment