Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46623 )
Change subject: realtek_mst_i2c_spi.c: Introduce ISP enter param
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/46623/1/realtek_mst_i2c_spi.c
File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/46623/1/realtek_mst_i2c_spi.c@514
PS1, Line 514: if (enter_isp) {
It would be nice to automatically detect whether entering ISP mode is necessary. […]
Ack
--
To view, visit
https://review.coreboot.org/c/flashrom/+/46623
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I58931ac8b42ab55829f102d243aea6fcfd632e3e
Gerrit-Change-Number: 46623
Gerrit-PatchSet: 2
Gerrit-Owner: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 24 Oct 2020 09:15:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment