Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Evan Benn.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70554 )
Change subject: tests/selfcheck.c: Fix on non-x86 machines ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: ``` In file included from ../../tests/include/test.h:28, from ../../tests/selfcheck.c:19: ../../tests/selfcheck.c: In function 'selfcheck_board_matches_table': ../../tests/selfcheck.c:142:21: error: 'board_matches_size' undeclared (first use in this function) 142 | assert_true(board_matches_size > 1); | ^~~~~~~~~~~~~~~~~~ ../../tests/selfcheck.c:142:21: note: each undeclared identifier is reported only once for each function it appears in ../../tests/selfcheck.c:143:21: error: 'board_matches' undeclared (first use in this function) 143 | assert_true(board_matches[board_matches_size - 1].vendor_name == NULL); ```
Looks like some more things need to be guarded.