10 Dec
2022
10 Dec
'22
8:39 p.m.
Attention is currently required from: Simon Buhrow, Aarya.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 )
Change subject: flashrom.c:Add a function to get list of sectors that need erasing ......................................................................
Patch Set 57:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65844/comment/05d21115_9cc42441 PS56, Line 1203: {
That would complicate the recursion probably?
Can you elaborate what you think would cause issue? Each function recuse has its own frame.
--
To view, visit https://review.coreboot.org/c/flashrom/+/65844
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic57ca1cca3d1646543f6b5939ba9c35db8d08256
Gerrit-Change-Number: 65844
Gerrit-PatchSet: 57
Gerrit-Owner: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Aarya aarya.chaumal@gmail.com
Gerrit-Comment-Date: Sat, 10 Dec 2022 23:39:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Aarya aarya.chaumal@gmail.com
Gerrit-MessageType: comment