22 May
2020
22 May
'20
12:41 a.m.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41533 )
Change subject: raiden_debug_spi.c: Adds support for USB SPI protocol V2 ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/flashrom/+/41533/3/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/3/raiden_debug_spi.c@722 PS3, Line 722: nd_command_v1(co seems like a change for the previous patches
https://review.coreboot.org/c/flashrom/+/41533/3/raiden_debug_spi.c@1108 PS3, Line 1108: NULL, was this tested..? This would clearly break this spi master.
--
To view, visit https://review.coreboot.org/c/flashrom/+/41533
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie356c63b521c0cc11a4946ffac128ec7139f0bec
Gerrit-Change-Number: 41533
Gerrit-PatchSet: 3
Gerrit-Owner: Brian Nemec bnemec@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Brian Nemec bnemec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 May 2020 00:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment