Attention is currently required from: Felix Singer, Thomas Heijligen.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58299 )
Change subject: ene: Move contents of programmer specific headers into C file
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Hmmm, looks a bit too mixed, IMO. Would it be worth to split "edi"
(i.e. the code on top up to edi_disable()) out into a separate file?
Or maybe inline the definitions? After this patch things are
interleaved:
* EDI (definitions)
* ENE (definitions)
* EDI (code)
* ENE (code)
IMO, this would make things easier (if splitting into two files is
a bad idea):
* EDI (definitions, code)
* ENE (definitions, code)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58299
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id22b6c8f4ecb727f759f020e3bef690301eb211b
Gerrit-Change-Number: 58299
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Thu, 14 Oct 2021 12:05:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment