31 Oct
2020
31 Oct
'20
7:28 p.m.
Septs has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46894 )
Change subject: test_build.sh: Move build test procedure to repository ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/46894/2/test_build.sh File test_build.sh:
https://review.coreboot.org/c/flashrom/+/46894/2/test_build.sh@2 PS2, Line 2: set -e Recommended to use "Bash Strict Mode" see http://redsymbol.net/articles/unofficial-bash-strict-mode/
https://review.coreboot.org/c/flashrom/+/46894/2/test_build.sh@7 PS2, Line 7: (cd out && ninja) Why not add `out` directory to `.gitignore`?
--
To view, visit https://review.coreboot.org/c/flashrom/+/46894
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I37a8e925d1b283c3b8f87cb3d0f1ed8920f2cf95
Gerrit-Change-Number: 46894
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Septs github@septs.pw
Gerrit-Comment-Date: Sat, 31 Oct 2020 19:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment