Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55119 )
Change subject: flashrom.c: replace enum programmer by struct programmer_entry*
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55119/comment/c3f7309d_6a78699e
PS3, Line 7: by
nit: replace <old> *with* <new>
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/55119/comment/e0421671_c7710885
PS3, Line 1570: chat.freenode.net
Reminds me we should update these. Or even drop direct references to specific communication channels, and link to a wiki page instead. But not in this change.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55119
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I478c56354d5f482010bfe1560489700bc889717a
Gerrit-Change-Number: 55119
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Xiang W
wxjstz@126.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Sun, 06 Jun 2021 14:36:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment