27 Sep
2022
27 Sep
'22
9:44 p.m.
Attention is currently required from: Thomas Heijligen, Jean THOMAS.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 )
Change subject: dirtyjtag: Add DirtyJTAG programmer ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4: Thanks for the patch! Just some formatting fixes.
File dirtyjtag_spi.c:
https://review.coreboot.org/c/flashrom/+/67878/comment/b8684a7e_8be68ccc PS4, Line 48: CMD_STOP = 0x00, Please use TAB instead of two spaces.
https://review.coreboot.org/c/flashrom/+/67878/comment/2a8f59df_e42984c1 PS4, Line 58: SIG_TCK = 1 << 1, TABs here too.
--
To view, visit https://review.coreboot.org/c/flashrom/+/67878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913
Gerrit-Change-Number: 67878
Gerrit-PatchSet: 4
Gerrit-Owner: Jean THOMAS virgule@jeanthomas.me
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Alexander Goncharov chat@joursoir.net
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Jean THOMAS virgule@jeanthomas.me
Gerrit-Comment-Date: Tue, 27 Sep 2022 21:44:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment