Attention is currently required from: Angel Pons, Nikolai Artemiev, Sergii Dmytruk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58480 )
Change subject: flashchips,writeprotect_ranges: add range decoding function
......................................................................
Patch Set 35: Code-Review+1
(3 comments)
File flash.h:
https://review.coreboot.org/c/flashrom/+/58480/comment/64ae2632_f4e8bb88
PS35, Line 311: size_t *start, size_t *len
Should we put output parameters first?
File writeprotect_ranges.c:
https://review.coreboot.org/c/flashrom/+/58480/comment/85f64148_89ad2fa1
PS35, Line 8: * the Free Software Foundation; version 2 of the License.
Can we have v2+?
https://review.coreboot.org/c/flashrom/+/58480/comment/4451d3b8_61283d57
PS35, Line 23: * various chips is more fully known.
I guess this would be something that's never 100% finished. Maybe not
worth a TODO.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58480
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id163ed80938a946a502ed116e48e8236e36eb203
Gerrit-Change-Number: 58480
Gerrit-PatchSet: 35
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Thu, 17 Feb 2022 18:12:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment