Attention is currently required from: Alan Green, Samir Ibradžić. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55695 )
Change subject: ft2232_spi: Revise comments about output pin states ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think I understand what's going on here: the intent of the csgpiol parameter was to specify additional GPIOL pins that should mirror the CS pin. My changes were attempting to use the same machinery as csgpiol, but to control a general GPIO mechanism.
Is that right?
That's how I comprehend it too.
(For unfortunate reasons, this worked fine with the ad-hoc programmer we are using, and I didn't notice the change in behavior it caused for other programmers).
It's probably a very limited issue. There are two programmer entries that change cs_bits, but it seems they could live with a constant 0 on the GPIO as well. What definitely broke (already before your patches) was the csgpiol option.
It's probably still useful to have a mechanism to set the GPIO pins,
Absolutely, yes. Angel has also already asked for it :)