3 Sep
2022
3 Sep
'22
2:14 a.m.
Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66671 )
Change subject: tree: Fix drivers to pass prog_param to pcidev_init() ......................................................................
Patch Set 7:
(1 comment)
File include/programmer.h:
https://review.coreboot.org/c/flashrom/+/66671/comment/a1dae453_cabbe534 PS3, Line 126: const char *
well it is higher typed now is it ok? usually prototypes don't need identifiers in truth and they te […]
It would be consistent with the other commits and the lines below. Please do that.
--
To view, visit https://review.coreboot.org/c/flashrom/+/66671
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie0c9d1c0866d44f64d037c596f2e30547fcfd58f
Gerrit-Change-Number: 66671
Gerrit-PatchSet: 7
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Sat, 03 Sep 2022 02:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment