Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44073 )
Change subject: sb600spi.c: Fix for 0x790b rev 0x61
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/flashrom/+/44073/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/44073/1//COMMIT_MSG@7
PS1, Line 7: 0x790b rev 0x61
Does this device have a prettier name?
https://review.coreboot.org/c/flashrom/+/44073/1//COMMIT_MSG@9
PS1, Line 9: Note that the
: read callback requires a memory mapping.
Why does read now require memory mapping? Does it affect original Yangtze?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/44073
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5ce63b5de863aed0442cb4ffeff981e9b2fa445b
Gerrit-Change-Number: 44073
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 31 Jul 2020 08:54:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment