29 May
2024
29 May
'24
3:11 a.m.
Attention is currently required from: Anastasia Klimchuk, Paul Menzel, ZhiYuanNJ.
Nicholas Chin has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82193?usp=email )
Change subject: ch347_spi: Add driver support for CH347F packaging ......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
Nicholas, just checking, do you approve the patch? […]
The current code looks fine to me, and my CH347T still seems to work fine with it (I'm assuming ZhiYuanNJ tested it with a CH347F; I don't have that variant). I approve of it, but I did want someone else to take a look as I'm not very active in flashrom development/review.
--
To view, visit https://review.coreboot.org/c/flashrom/+/82193?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I693baf1a0d9dc20757f56fba626b5f5ad20f71dd
Gerrit-Change-Number: 82193
Gerrit-PatchSet: 11
Gerrit-Owner: ZhiYuanNJ
Gerrit-Reviewer: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: ZhiYuanNJ
Gerrit-Comment-Date: Wed, 29 May 2024 03:11:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org