Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46140 )
Change subject: s25f.c: implement probing and block erasers for Spansion ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/flashrom/+/46140/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46140/11//COMMIT_MSG@7 PS11, Line 7: import from cros flashrom
still says "import". What about a commit short msg that actually says what this does? […]
Done
https://review.coreboot.org/c/flashrom/+/46140/11//COMMIT_MSG@12 PS11, Line 12: Brings over basic support for s25f chips
Can you please elaborate here with details. […]
Done
https://review.coreboot.org/c/flashrom/+/46140/11//COMMIT_MSG@12 PS11, Line 12: but does not include : writeprotect support which will be added in a following patch.
That is irrelevant here.
Done