Attention is currently required from: Anastasia Klimchuk, Hsuan Ting Chen, Stefan Reinauer.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81356?usp=email )
Change subject: ich: Add names for region 5, 9, 10, 11, 12, 13, 15
......................................................................
Patch Set 1:
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/81356/comment/5c1681e1_94d906a1 :
PS1, Line 521: msg_pdbg2(" FD BIOS ME GbE Pltf DE BIOS2 Reg7 EC DE2 ");
Yes, we used to pad names to 4 characters (lines 534 and 538). […]
Before: (width=84)
```
--- Details ---
FD BIOS ME GbE Pltf Reg5 Reg6 Reg7 EC Reg9 RegA RegB RegC RegD RegE RegF
BIOS r rw r r
ME r rw
```
After: (width=115)
```
--- Details ---
FD BIOS ME GbE Pltf DE BIOS2 Reg7 EC DE2 IE 10GbE0 10GbE1 RegD RegE PTT
BIOS r rw r r
ME r rw
```
--
To view, visit
https://review.coreboot.org/c/flashrom/+/81356?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I3b164ce4ae84bfd523fcd8be416c5d13183ed632
Gerrit-Change-Number: 81356
Gerrit-PatchSet: 1
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 26 Mar 2024 06:58:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment