Attention is currently required from: Peter Marheine, Simon Arlott.
Anastasia Klimchuk has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email )
Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ......................................................................
Patch Set 4:
(4 comments)
Patchset:
PS2:
I've added an entry to the release notes. […]
Alright, but you can change your mind later! You can keep it working as is, not necessarily adding new stuff.
File spidriver.c:
https://review.coreboot.org/c/flashrom/+/86411/comment/8eedddca_d2e4cd24?usp... : PS2, Line 81: {
It reduces the scope of "buf" so that it's not being shadowed later and can't accidentally be used.
I see, thank you
https://review.coreboot.org/c/flashrom/+/86411/comment/4fbc12b6_b64e5732?usp... : PS2, Line 136: /* Read and write */
There's no read API, because something must always be written on the SPI bus in order to read from i […]
Thank you!
File spidriver.c:
https://review.coreboot.org/c/flashrom/+/86411/comment/ad213f4a_28b91389?usp... : PS4, Line 307: fw_version >= 2 Just to double-check, it's 2 as it's also described on line 267 above? I noticed that fw_version condition changed from 1->2->1->2 between patchsets, but you mean 2 right?