Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39965 )
Change subject: pcidev: On arm64 we are not getting a valid BAR0 address
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/flashrom/+/39965/3/pcidev.c
File pcidev.c:
https://review.coreboot.org/c/flashrom/+/39965/3/pcidev.c@54
PS3, Line 54: int bar
unsigned bar
https://review.coreboot.org/c/flashrom/+/39965/3/pcidev.c@66
PS3, Line 66: bar_number = pci_bar_number_from_offset(bar);
why not just `int bar_number = bar < 6 ? bar : -1;` here and make bar unsigned?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/39965
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8bd32c6344b0831a949c3853abeb84905420922a
Gerrit-Change-Number: 39965
Gerrit-PatchSet: 3
Gerrit-Owner: Martijn Berger
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Apr 2020 01:07:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment