24 Nov
2020
24 Nov
'20
6:42 a.m.
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36432 )
Change subject: sb600spi.c: Remove 'amd_gen' out of global state ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/flashrom/+/36432/2/sb600spi.c File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/36432/2/sb600spi.c@75 PS2, Line 75: amd_gen = CHIPSET_SB6XX; Could I convince you to make all of these early returns?
--
To view, visit https://review.coreboot.org/c/flashrom/+/36432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I99fbad9486123c6b921eab83756de54a53ddfa7a
Gerrit-Change-Number: 36432
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 24 Nov 2020 06:42:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment