Attention is currently required from: Mike Banon, Nico Huber, Victor Ding, Matt DeVillier, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Iru Cai, Alexandru Gagniuc.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56475 )
Change subject: ene_lpc: remove ENE LPC programmer
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
It's not known if the code worked on any device when merged.
I highly doubt it... first issue when testing here: missing iopl/ioperm \o/
It's also not known if the code is device specific and what firmware, if any, is expected on the EC.
Firmware is definitely expected. Take a look at lines 138ff. These are EC fw commands.
Unfortunately, I'm having massive issues with EDI flashing atm. It looks my EC is dying .... (It worked many times before without problems.) That means I can't test/fix this programmer, anyway :/
I'd say it's best to get it through a proper review if anybody finds a use case for it. Same story for the follow-up commit.
Ack.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/56475
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f40db22c42c04ce029c4defd837e05ebb550c9b
Gerrit-Change-Number: 56475
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Ding
victording@google.com
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Iru Cai
mytbk920423@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Mike Banon
mikebdp2@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Victor Ding
victording@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Iru Cai
mytbk920423@gmail.com
Gerrit-Attention: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Attention: Iru Cai
mytbk920423@gmail.com
Gerrit-Comment-Date: Tue, 21 Sep 2021 00:14:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Comment-In-Reply-To: Iru Cai
mytbk920423@gmail.com
Gerrit-MessageType: comment