25 Apr
2022
25 Apr
'22
9:53 a.m.
Attention is currently required from: Nico Huber, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62948 )
Change subject: tests: Remove mock struct pci_dev, use real pci symbols in tests ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Yes! It came up in the conversations earlier, this is definitely option. […]
This patch would conflict with CB:63724 when not building with -Dprogrammer=(auto*|all|group_pci|<pci_based_programmer_name>)
*auto and with libpci found
--
To view, visit https://review.coreboot.org/c/flashrom/+/62948
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1206fbdca392f190066a364376ce0db28071e53c
Gerrit-Change-Number: 62948
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 25 Apr 2022 09:53:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment