27 Jul
2019
27 Jul
'19
11:25 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30409 )
Change subject: Fix -Wsign-compare trouble ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/flashrom/+/30409/5/fmap.c File fmap.c:
https://review.coreboot.org/c/flashrom/+/30409/5/fmap.c@99 PS5, Line 99: (len - sizeof(struct fmap)) Not sure anymore why I placed the parentheses. It looks like it would be safer without? i.e. do the calculation as signed, so the overflow wouldn't be a problem?
--
To view, visit https://review.coreboot.org/c/flashrom/+/30409
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305
Gerrit-Change-Number: 30409
Gerrit-PatchSet: 5
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 27 Jul 2019 23:25:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment