Werner Zeh has posted comments on this change. ( https://review.coreboot.org/23203 )
Change subject: Add support to get layout from fmap (e.g. coreboot rom) ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/#/c/23203/15/cli_classic.c File cli_classic.c:
https://review.coreboot.org/#/c/23203/15/cli_classic.c@247 PS15, Line 247: case OPTION_FMAP_FILE: So again (as said in patchset 10 already): If you, for now, want to have --ifd and --fmap-file be exclusive you have to check in the IFD-case for fmapfile as the order on the parameters is not strictly enforced. I know that we need something smarter here one day but for now we have to care about it as the --ifd will win the race without even a warning
Or do I miss something?