Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59529 )
Change subject: spi25_statusreg: delete read_status_register()
......................................................................
Patch Set 4:
(3 comments)
File it87spi.c:
https://review.coreboot.org/c/flashrom/+/59529/comment/9571bb9d_3745f02d
PS4, Line 136: while (true)
I am curious, can this ever become an infinite loop? I understand it was like this before ;)
https://review.coreboot.org/c/flashrom/+/59529/comment/650b9665_da59c730
PS4, Line 139: return 1;
Can we propagate error code from spi_read_register?
https://review.coreboot.org/c/flashrom/+/59529/comment/f7676249_ac4e06b2
PS4, Line 288: return 1;
Looks like another opportunity to propagate error code!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59529
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I146b4b5439872e66c5d33e156451a729d248c7da
Gerrit-Change-Number: 59529
Gerrit-PatchSet: 4
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Mon, 22 Nov 2021 03:26:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment