Attention is currently required from: Edward O'Callaghan, Daniel Campello, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59921 )
Change subject: flashrom.c: extract operation only uses layout files ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I am not sure what the concern is since read_flash_to_file() has a singular call site
It has two call sites (not one) at this patch, and only after CB:59291 it becomes a singular call site. So this argument actually supports my side :)
CB:59291 is simply a matter of inlining read_flash_to_file() to the call site
CB:59291 does more than that, it eliminates a call site from cli_classic and then inlines to one remaining call site.
I understand that after both patches are merged, the end result is the same no matter in what sequence both patches merged. But at the moment two patches are not in a chain, and I see from you both comments that you both prefer merge one (this one) as priority and the other one sometime later. In my eyes, just merging this one patch leaves tree in a state where I don't want it to be. CB:59291 would fix the state to be normal again. That's why I want two patches be in a chain and merged together.
I understand there is a bug that needs to be fixed. I very much want to fix the bug. Not only because I discovered it, but also because I am probably the only person on the planet who is actually blocked by the bug (my work is blocked CB:59532). So yes I want to fix the bug.
a refactor patch that simply inlines a function
It does more than that, it leaves tree in a better state, where bug fix looks good.
A very practical question: how far CB:59291 is from being merged? I think it's very close.