Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63832 )
Change subject: meson: add option to disable tests
......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63832/comment/9a2fc7a0_810b4e56
PS6, Line 11: to
To
https://review.coreboot.org/c/flashrom/+/63832/comment/3f72e220_43eea6bf
PS6, Line 12: -
Add a dot at the end.
File meson.build:
https://review.coreboot.org/c/flashrom/+/63832/comment/0d6c5e4c_212972fd
PS6, Line 509: # .allowed() is introduced in 0.59.0
Rather put this in the commit message instead here.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63832
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I384c904c577b265dfe36bf46bf07c641bc29de9b
Gerrit-Change-Number: 63832
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 03 May 2022 15:40:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
