[flashrom-gerrit] [S] Change in flashrom[1.2.x]: linux_mtd: check ioctl() return value properly

[Nico Huber (Code Review)]

Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev.

Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Nikolai Artemiev,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/flashrom/+/67874

to review the following change.

Change subject: linux_mtd: check ioctl() return value properly
......................................................................

linux_mtd: check ioctl() return value properly

Make the linux_mtd driver treat any negative return value from the
MEMERASE ioctl as an error. Previously it only treated -1 as an error.

BUG=b:213561594,b:210973586,b:182223106
BRANCH=none
TEST=builds

Change-Id: I40cfbdee2ab608fbe6c17d9cac6ec53ff224d9a4
Signed-off-by: Nikolai Artemiev 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/60996
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
Reviewed-by: Edward O'Callaghan 
---
M linux_mtd.c
1 file changed, 26 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/67874/1

diff --git a/linux_mtd.c b/linux_mtd.c
index 22702e9..316c8ed 100644
--- a/linux_mtd.c
+++ b/linux_mtd.c
@@ -280,9 +280,11 @@
    		.length = mtd_erasesize,
    	};

-		if (ioctl(fileno(dev_fp), MEMERASE, &erase_info) == -1) {
-			msg_perr("%s: ioctl: %s\n", __func__, strerror(errno));
-			return 1;
+		int ret = ioctl(fileno(dev_fp), MEMERASE, &erase_info);
+		if (ret < 0) {
+		        msg_perr("%s: MEMERASE ioctl call returned %d, error: %s\n",
+		                 __func__, ret, strerror(errno));
+		        return 1;
    	}
    }