10 Apr
2022
10 Apr
'22
1:47 p.m.
Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63489 )
Change subject: tests: Fix -Wmissing-prototypes warnings ......................................................................
Patch Set 1:
(1 comment)
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/63489/comment/abc64abb_38974ac9 PS1, Line 50: static
making all the functions static local is its own patch.
It's part of fixing the warnings, though.
--
To view, visit https://review.coreboot.org/c/flashrom/+/63489
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia1ff22deb2354569f277649c6575ef2d5ffbb6e0
Gerrit-Change-Number: 63489
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Peter Marheine pmarheine@chromium.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Sun, 10 Apr 2022 13:47:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment