Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/59743 )
Change subject: tests: Upgrade linux_mtd test to run probe lifecycle ......................................................................
tests: Upgrade linux_mtd test to run probe lifecycle
No additional mocks are needed, because linux_mtd is doing most of the job in init function.
BUG=b:181803212 TEST=ninja test
Change-Id: I74436f36f628680c22c7225b1584f06464307775 Signed-off-by: Anastasia Klimchuk aklm@chromium.org Reviewed-on: https://review.coreboot.org/c/flashrom/+/59743 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Thomas Heijligen src@posteo.de --- M tests/lifecycle.c M tests/tests.c M tests/tests.h 3 files changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/tests/lifecycle.c b/tests/lifecycle.c index c439ff7..e48d94e 100644 --- a/tests/lifecycle.c +++ b/tests/lifecycle.c @@ -294,7 +294,7 @@ return 0; }
-void linux_mtd_basic_lifecycle_test_success(void **state) +void linux_mtd_probe_lifecycle_test_success(void **state) { #if CONFIG_LINUX_MTD == 1 struct linux_mtd_io_state linux_mtd_io_state = { NULL }; @@ -307,7 +307,7 @@
io_mock_register(&linux_mtd_io);
- run_basic_lifecycle(state, &programmer_linux_mtd, ""); + run_probe_lifecycle(state, &programmer_linux_mtd, "", "Opaque flash chip");
io_mock_register(NULL); #else diff --git a/tests/tests.c b/tests/tests.c index 0f16041..34c01ea 100644 --- a/tests/tests.c +++ b/tests/tests.c @@ -368,7 +368,7 @@ cmocka_unit_test(nicrealtek_basic_lifecycle_test_success), cmocka_unit_test(raiden_debug_basic_lifecycle_test_success), cmocka_unit_test(dediprog_basic_lifecycle_test_success), - cmocka_unit_test(linux_mtd_basic_lifecycle_test_success), + cmocka_unit_test(linux_mtd_probe_lifecycle_test_success), cmocka_unit_test(linux_spi_basic_lifecycle_test_success), cmocka_unit_test(realtek_mst_basic_lifecycle_test_success), }; diff --git a/tests/tests.h b/tests/tests.h index 5f05abf..672ec1f 100644 --- a/tests/tests.h +++ b/tests/tests.h @@ -46,7 +46,7 @@ void nicrealtek_basic_lifecycle_test_success(void **state); void raiden_debug_basic_lifecycle_test_success(void **state); void dediprog_basic_lifecycle_test_success(void **state); -void linux_mtd_basic_lifecycle_test_success(void **state); +void linux_mtd_probe_lifecycle_test_success(void **state); void linux_spi_basic_lifecycle_test_success(void **state); void realtek_mst_basic_lifecycle_test_success(void **state);
4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.