Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46623 )
Change subject: realtek_mst_i2c_spi.c: Introduce ISP enter param ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/46623/1/realtek_mst_i2c_spi.c File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/46623/1/realtek_mst_i2c_spi.c@514 PS1, Line 514: if (enter_isp) {
I wonder, is there any way to know if we're in ISP mode already?
Seems a little out of scope for this change but Shiyu would need to ask RTK that. I suspect the enter_isp_mode() function would need to be modified to return another exit code >0 depending on the status.