Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33347 )
Change subject: ichspi.c: Remove unneeded 'else' ......................................................................
Patch Set 3:
Elyes, did you check if the upstream (Linux kernel) checkpatch also complains about these `else`s?
As I told you on IRC, that would be enough reason for me to merge these patches.
Thank you for the review. Yes I did. I've used https://raw.githubusercontent.com/torvalds/linux/master/scripts/checkpatch.p... and here is for example the log of "./checkpatch.pl --no-tree --file ichspi.c" : https://pastebin.com/H9W73U6h as you can see, we have : "WARNING: else is not generally useful after a break or return #1249: FILE: ichspi.c:1249:
return 4 * 1024;
- } else {
"
Thanks for the confirmation.