16 May
2023
16 May
'23
5:54 p.m.
Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270 )
Change subject: doc: Add build instructions for NI-845x on Windows ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File doc/dev_guide/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/75270/comment/7bc9f991_6bd5a5be PS1, Line 92: for **32-bit**. Add ``-Dprogrammer=ni845x_spi`` to your meson configuration.
We've the plan to move the make related build instructions in a separate document. See CB:75125. […]
Ah okay, I have not been aware of that. In this case it is fine for me.
--
To view, visit https://review.coreboot.org/c/flashrom/+/75270
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97ad08632f35aa241b3d19d9ce7711146e3f1f4a
Gerrit-Change-Number: 75270
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Tue, 16 May 2023 17:54:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Miklós Márton martonmiklosqdev@gmail.com
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Gerrit-MessageType: comment