Attention is currently required from: Aarya, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77747?usp=email )
Change subject: [WIP] Fix double invocation of erasers ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: This is my attempt to fix the double invocation of every eraser, what do you think about it? I am not sure this is a perfect way, really interested in your thoughts. The issue was: every eraser called twice. This would not be obvious in the real run of flashrom, because at the end the chip is erased and the memory state is correct. But in the test (see next patch CB:67535) I am verifying erasers are called in correct order and the test is recording all invocations, and that's how I discovered the double invocations.