Andrey Pronin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43527 )
Change subject: raiden_debug_spi: add param for a custom reset setup
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/flashrom/+/43527/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/43527/3//COMMIT_MSG@9
PS3, Line 9: Cr50
`The Chromium TPM Cr50 asserts...` […]
It's technically not a TPM, and haven't seen it being called a "chromium tpm" before. If cr50 doesn't work, we can go with "H1 firmware" or "Titan C firmware" (both are valid names for the chip, one older but still used, one newer marketing-sounding) or "GSC firmware"
--
To view, visit
https://review.coreboot.org/c/flashrom/+/43527
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2da26469120c5304bc129b5578fcb7ca805fc1d1
Gerrit-Change-Number: 43527
Gerrit-PatchSet: 3
Gerrit-Owner: Mary Ruthven
mruthven@chromium.org
Gerrit-Reviewer: Brian Nemec
bnemec@chromium.org
Gerrit-Reviewer: Brian Nemec
bnemec@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Pronin
apronin@chromium.org
Gerrit-CC: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Comment-Date: Mon, 20 Jul 2020 22:15:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment