Eizan Miyamoto has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47655 )
Change subject: it85spi.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/flashrom/+/47655/5/it85spi.c
File it85spi.c:
https://review.coreboot.org/c/flashrom/+/47655/5/it85spi.c@311
PS5, Line 311: calloc
nit: Maybe to make it super-obvious, add a comment that the free() of data is handled inside it85xx_ […]
from out-of-band comms, it's idiomatic in this codebase to assume that things will be deinitialized by the presence of the call to register_shutdown.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47655
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I389d34d62e753c012910aa5ff24a496b24a4753c
Gerrit-Change-Number: 47655
Gerrit-PatchSet: 5
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Eizan Miyamoto
eizan@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Nov 2020 02:29:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eizan Miyamoto
eizan@chromium.org
Gerrit-MessageType: comment