Attention is currently required from: Peter Marheine.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54147 )
Change subject: libflashrom: clear layout on flashrom_layout_release
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/54147/comment/71778377_b2b461b6
PS2, Line 10: (as is currently always
: the case)
Not always the case... See --layout --fmap --ifd
https://review.coreboot.org/c/flashrom/+/54147/comment/6353da3c_4032ee8f
PS2, Line 14: it's always the global layout
how can user do this on libflashrom? I think the global layout is only used by cli_classic
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54147
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8ba4b356f2a40ccbfd4e91f81af01d5f6a6de515
Gerrit-Change-Number: 54147
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Thu, 13 May 2021 02:35:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment