Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45674 )
Change subject: realtek_mst_i2c_spi.c: Introduce MCU reset param
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/45674/10/realtek_mst_i2c_spi.c
File realtek_mst_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/45674/10/realtek_mst_i2c_spi.c@476
PS10, Line 476: if (reset) {
Hey Angel, thanks for your feedback! […]
Hi Edward, thanks to you!
I believe removing the pre-reset would be best done in a separate patch, with this one as a follow-up. This way, its commit message can explain why the pre-reset is not required.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/45674
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib70bf7399e7541f30b6905cdb950a6fb7b74ae18
Gerrit-Change-Number: 45674
Gerrit-PatchSet: 11
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Oct 2020 08:16:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment