11 May
2019
11 May
'19
3:04 p.m.
Stefan T has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31973 )
Change subject: ich_descriptors_tool: Fix -Wmissing-braces warning ......................................................................
Patch Set 1: Code-Review-1
This was a long-standing bug in clang that is fixed in clang 6 and newer: https://bugs.llvm.org/show_bug.cgi?id=21689
Using {0} is *the* standard way to tell the compiler to initialize all fields (recursively) to its neutral value. Back in the times I would have put a -2 on this.
--
To view, visit https://review.coreboot.org/c/flashrom/+/31973
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3cbf6bb6bdc34b812c2321c6674051af991362b4
Gerrit-Change-Number: 31973
Gerrit-PatchSet: 1
Gerrit-Owner: Alex James theracermaster@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Stefan T stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 11 May 2019 15:04:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment