12 May
2023
12 May
'23
12:47 a.m.
Attention is currently required from: Miklós Márton, Thomas Heijligen, Anastasia Klimchuk.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74963 )
Change subject: ni845x_spi: support building with Meson ......................................................................
Patch Set 3:
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/74963/comment/c772c9b2_0bdee4b8 PS3, Line 162: dependencies : cc.find_library(
Isn't the cc. […]
No, because specifying `header_include_directories` doesn't cause the returned dep to add those directories to the include search path. I tried `libni845x = cc.find_library(...)` and the build failed with an inability to find `ni845x.h`.
--
To view, visit https://review.coreboot.org/c/flashrom/+/74963
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I90e85c424f97898b47bf0a3d78672d6c25af12b0
Gerrit-Change-Number: 74963
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Fri, 12 May 2023 00:47:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Gerrit-MessageType: comment