Attention is currently required from: Subrata Banik, Edward O'Callaghan, Angel Pons.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69129 )
Change subject: writeprotect,ichspi,spi25: handle register access constraints ......................................................................
Patch Set 10:
(1 comment)
File spi25_statusreg.c:
https://review.coreboot.org/c/flashrom/+/69129/comment/ac875194_b83e75ee PS7, Line 133: /* Some SPI masters like ICH7/ICH9 block opcodes for writing SR2/SR3/etc. */
Do they? I thought they are swseq and this was only a limitation of hwseq?
I thought so too but when I was debugging cyan/wizpig failures in b/240229722 I found that it didn't work.
Looking at again, ichspi actually skips the reprogram_opcodes code path if ichspi_lock is set, maybe it would work if we forced it to take that code path. But that might break something else.
We should still call probe_opcode here but I'll drop the comment since it might be misleading and it isn't necessary to understand what's going on.